Re: 2.6.12-mm1

From: Takashi Iwai
Date: Tue Jun 21 2005 - 12:21:59 EST


At Tue, 21 Jun 2005 19:02:24 +0200,
Brice Goglin wrote:
>
> Le 21.06.2005 18:27, Takashi Iwai a écrit :
> > Well, this disables the h/w volume controls completely, so it's not a
> > generic solution.
>
> Well, I though this wouldn't break anything since HW_INT_ENABLE is not
> set there is 2.6.12. Is this a new feature ?

Yes. It enables hardware volume contorl - volume up/down and
mute/unmute via keys on your laptop.

> How is this supposed to work ? Does HW_INT_ENABLE in this outw require
> some other parts of the git-alsa.patch ?

Yes, the whole tasklet and m3_hv_quirk stuff.

> > Does the patch below have any improvement?
>
> No, same error.
>
> Your second patch gives same error too, but it also made my beeper
> generate a very sharp sound during the whole boot.

Could you give the output of lspci -nv? If it's listed in
m3_hw_quirk_list, the h/w volume control is enabled in the code
indeed. Try to comment out the entry (together with my second
patch).

> Actually, I can't test after boot since -mm1 crashes a little bit
> later on my laptop. That's why I didn't notice any eventual h/w
> volume control breakage with my patch :)
> If necessary, I can try with git-alsa.patch applied on top of 2.6.12.

This might include some changes applied to mm, but at least, you can
apply only the patch to maestro3.c.


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/