RE: [PATCH] Priority Lists for the RT mutex

[Perez-Gonzalez, Inaky]

>-----Original Message-----
>From: tmp@xxxxxxxxxx [mailto:tmp@xxxxxxxxxx] On Behalf Of Oleg Nesterov
>Sent: Friday, May 06, 2005 4:13 AM
>To: linux-kernel@xxxxxxxxxxxxxxx; Daniel Walker; Perez-Gonzalez, Inaky;
Ingo Molnar
>Subject: Re: [PATCH] Priority Lists for the RT mutex
>
>Oleg Nesterov wrote:
>>
>> Daniel Walker wrote:
>> >
>> > Description:
>> > 	This patch adds the priority list data structure from Inaky
Perez-Gonzalez
>> > to the Preempt Real-Time mutex.
>> >
>> ...
>>
>> I can't understand how this can work.
>
>And I think it is possible to simplify plist's design.
>
> ...
>
>					 struct plist, prio_list);
>			goto eq_prio;
>		}
>
>lt_prio:
>	list_add_tail(&new->prio_list, &pos->prio_list);
>eq_prio:
>	list_add_tail(&new->node_list, &pos->node_list);
>}

Isn't this adding them to *both* lists in the lt_prio
case? I don't understand what do you want to accomplish
in this case.

[like for example, if the list is empty and you add one,
it will start a new node_list, but you have also added
it to the head's prio_list] 

If you ware changing the operational mode, can you please
explain your change in more detail?

It could also be I have *the* headache...but hey :)

-- Inaky 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/