Re: [PATCH 2/3] add open iscsi netlink interface to iscsitransport class

From: Arjan van de Ven
Date: Thu May 05 2005 - 18:54:41 EST


On Thu, 2005-05-05 at 21:39 +1000, Herbert Xu wrote:
> YOSHIFUJI Hideaki / ???? <yoshfuji@xxxxxxxxxxxxxx> wrote:
> > In article <42798AC1.2010308@xxxxxxxxxxx> (at Wed, 04 May 2005 19:53:53 -0700), Mike Christie <michaelc@xxxxxxxxxxx> says:
> >
> >> +struct iscsi_uevent {
> > :
> >> +} __attribute__ ((aligned (sizeof(unsigned long))));
> >
> > I think it'd be better to use sizeof(uint64_t) or something.
>
> Is there a benefit in aligning on 64-bit boundaries for 32-bit platforms?


why align at all as opposed to just letting the compiler figure it out.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/