Re: [PATCH 2/3] add open iscsi netlink interface to iscsitransport class

[YOSHIFUJI Hideaki / 吉藤英明]

In article <E1DTehn-0005gJ-00@xxxxxxxxxxxxxxxxxxxxxxxx> (at Thu, 05 May 2005 21:39:47 +1000), Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> says:

> YOSHIFUJI Hideaki / ???? <yoshfuji@xxxxxxxxxxxxxx> wrote:
> > In article <42798AC1.2010308@xxxxxxxxxxx> (at Wed, 04 May 2005 19:53:53 -0700), Mike Christie <michaelc@xxxxxxxxxxx> says:
> > 
> >> +struct iscsi_uevent {
> > :
> >> +} __attribute__ ((aligned (sizeof(unsigned long))));
> > 
> > I think it'd be better to use sizeof(uint64_t) or something.
> 
> Is there a benefit in aligning on 64-bit boundaries for 32-bit platforms?

Well, this if for avoiding inconsistency between kernel and userspace.
If you use unsigned long, sizeof(unsigned long) may be inconssitent
between kernel and userland like this:
  kernel:    sizeof(unsigned long) == 8
  userspace: sizeof(unsigned long) == 4

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/