Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero

From: Christoph Hellwig
Date: Fri Apr 15 2005 - 06:33:10 EST


On Fri, Apr 15, 2005 at 12:29:08PM +0100, Matthew Wilcox wrote:
> > I think Linux only complained if we're using some typedef that actually
> > may be signed. For fcntl that 'arg' argument is unsigned and that's hardcoded
> > in the ABI. So the check doesn't make sense at all.
>
> No, it was exactly this patch:
> http://www.ussg.iu.edu/hypermail/linux/kernel/0401.0/1816.html

Hmm. Looks I absolutely disagree with Linus on this one ;-)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/