RE: [Hotplug_sig] RE: [PATCH 1/6]sep initializing rework

From: Protasevich, Natalie
Date: Tue Apr 12 2005 - 19:25:10 EST



> I forgot to mention that while working on the patch,
> I found a problem with ACPI driver while counting number of records
> in acpi_table_parse_madt_family() (drivers/acpi/tables.c).
> It always returns 0 for the number of records, so this should be
> fixed for my patch to work properly, since I rely on number of
> lapic entries found by ACPI. I am going to post a bugzilla on this,
> for now it worked for me as follows:
> while (((unsigned long) entry) + sizeof(acpi_table_entry_header) <
madt_end) {
> if (entry->type == entry_id &&
> - (!max_entries || count++ < max_entries)
> + ((count++ < max_entries) || !max_entries))
> (it wasn't incrementing count if max_entries are >0 ).

Please disregard this: I couldn't reproduce it anymore, looks like it
only happened on one system (I cannot remember on which one) and seems
to work OK without the fix on any machine I'm trying it now...

Thanks,
--Natalie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/