Re: [2.6 patch] fs/attr.c: fix check after use

From: Chris Wright
Date: Wed Mar 23 2005 - 22:31:11 EST


* Adrian Bunk (bunk@xxxxxxxxx) wrote:
> --- linux-2.6.12-rc1-mm1-full/fs/attr.c.old 2005-03-23 04:44:40.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/fs/attr.c 2005-03-23 04:45:40.000000000 +0100
> @@ -112,7 +112,7 @@
> int notify_change(struct dentry * dentry, struct iattr * attr)
> {
> struct inode *inode = dentry->d_inode;
> - mode_t mode = inode->i_mode;
> + mode_t mode;
> int error;
> struct timespec now = current_fs_time(inode->i_sb);

looks like same issue here too?

> unsigned int ia_valid = attr->ia_valid;
> @@ -120,6 +120,8 @@
> if (!inode)
> BUG();
>
> + mode = inode->i_mode;
> +
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/