Re: 2.6.12-rc1-mm1: Kernel BUG at pci:389

[Pavel Machek]

Hi!

> Will this do it for the moment?

Its certainly better.

What about

> > > +static int acpi_pci_set_power_state(struct pci_dev *dev,
> > pci_power_t state)
> > > +{
> > > +     acpi_handle handle = DEVICE_ACPI_HANDLE(&dev->dev);
> > > +     static int state_conv[] = {
> > > +             [0] = 0,
> > > +             [1] = 1,
> > > +             [2] = 2,
> > > +             [3] = 3,
> > > +             [4] = 3
> > > +     };
> > > +     int acpi_state = state_conv[(int __force) state];

...this force? Then platform_pci_choose_state should not be NULL by
default and acpi_pci_choose_state should really have some more
reasonable calling convention.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/