Re: [BUG ?] smbfs open always succeeds

From: tvrtko . ursulin
Date: Tue Nov 30 2004 - 10:29:04 EST


>I posted a possible bug report to the maintainer about 10 days ago but
>with no response, therefore here it goes again. As far a I can tell it is
>common for both 2.4 and 2.6.
>
>Sorry if this is not a bug but some hidden functionality!
>
>--- snippet from the original mail to the maintainer ---
>
>Looking at linux-2.6.9/fs/smbfs/file.c line 365 (end of the smb_file_open
>function). Shouldn't it be "return result;" instead of "return 0;" ?
>
>I've been tracing some strange behaviour and this fixed it for me. But I
>am far away from being an expert. :)

I investigated a bit and found a nfs_open function at
linux-2.6.9/fs/nfs/inode.c line 906 which also always returns 0. So is
this a network filesystem way of handling opens and not a bug after all? I
am not sure though that both nfs and smbfs operate in the same way and am
not claiming that.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/