Re: pci-resume patch from 2.6.7-rc2 breakes S3 resume on somemachines

[Benjamin Herrenschmidt]

On Mon, 2004-11-22 at 05:34 +0100, Matthias Hentges wrote:
> Am Montag, den 22.11.2004, 08:39 +1100 schrieb Benjamin Herrenschmidt:
> 
> > That "update only what changed" makes little sense
> 
> Sorry, I was merely stating my observations.
> 
> >  ... can you send me
> > the lspci state of the Intel bridge before you try to resume it ? I
> > suspect our pci_restore_state() should be smarter, that is check if
> > something changed (a BAR), if yes, switch mem/io off, restore the BARs,
> > then switch mem/io back on...
> 
> Attached.

Ok, it's clearly visible that your CPU->AGP bridge isn't properly
restored. I can't tell if the "default" resume code is enough tho, but
it's fairly probably that this isn't the only problem, and that the
video chip itself isn't restored neither...

I don't think the default resume code is to blame here, though the CPU
to AGP bridge may need some special restore code restoring more than
just it's config space (very probable even). I suspect there is some
ACPI trickery here that should be happening and isn't but my knowledge
of ACPI isn't that great.

Once the config space is resumed, I suppose doing a soft-boot of the
card with the BIOS would work, but then, that means preventing anything
from actually touching the video card until that happens... 

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/