Re: pci-resume patch from 2.6.7-rc2 breakes S3 resume on somemachines

From: Matthias Hentges
Date: Sun Nov 21 2004 - 23:36:20 EST


Am Montag, den 22.11.2004, 08:39 +1100 schrieb Benjamin Herrenschmidt:

> That "update only what changed" makes little sense

Sorry, I was merely stating my observations.

> ... can you send me
> the lspci state of the Intel bridge before you try to resume it ? I
> suspect our pci_restore_state() should be smarter, that is check if
> something changed (a BAR), if yes, switch mem/io off, restore the BARs,
> then switch mem/io back on...

Attached.

Thanks!
--
Matthias Hentges
Cologne / Germany

[www.hentges.net] -> PGP welcome, HTML tolerated
ICQ: 97 26 97 4 -> No files, no URL's

My OS: Debian SID. Geek by Nature, Linux by Choice

Attachment: dmesg.txt.gz
Description: GNU Zip compressed data

Attachment: kernel.config.gz
Description: GNU Zip compressed data

Attachment: lspci-vvvxxx_after_restoring_PCI.txt.gz
Description: GNU Zip compressed data

Attachment: lspci-vvvxxx_after_resuming.txt.gz
Description: GNU Zip compressed data

Attachment: lspci-vvvxxx_before_suspending.txt.gz
Description: GNU Zip compressed data

CPU0
0: 411306 XT-PIC timer
1: 510 XT-PIC i8042
2: 0 XT-PIC cascade
4: 8 XT-PIC serial
5: 1385 XT-PIC eth0
9: 9 XT-PIC acpi
12: 803 XT-PIC i8042
14: 2036 XT-PIC ide0
15: 21 XT-PIC ide1
NMI: 0
ERR: 0