Re: patch for sysfs in the cyclades driver

From: Greg KH
Date: Thu Nov 04 2004 - 13:45:26 EST


On Thu, Nov 04, 2004 at 09:40:21AM -0800, Roland Dreier wrote:
> Marcelo> ------ Greg answer was:
>
> Greg> For a driver only attribute, you want them to show up in the
> Greg> place for the driver (like under
> Greg> /sys/bus/pci/driver/MY_FOO_DRIVER/). To do that use the
> Greg> DRIVER_ATTR() and the driver_add_file() functions. For
> Greg> examples, see the other drivers that use these functions.
>
> I think Greg may have misunderstood the question and told you how to
> expose per-driver attributes. But I think the attributes you want
> really are per-device and should be attached to the class_device, not
> the driver.

Heh, yes. Per-driver attributes go in the driver's directory. Per port
attributes go in the port's directory. Simple as that :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/