Re: [PATCH] Export ata_scsi_simulate() for use by non-libata drivers

[Jeff Garzik]

Mark Lord wrote:
> +void ata_scsi_simulate(u16 *id,
> +		      struct scsi_cmnd *cmd,
> +		      void (*done)(struct scsi_cmnd *));

That you are defining a public function in multiple files should be a 
hint that something is still missing...  :)  Put a prototype in 
linux/libata.h just like the other public functions, and the patch will 
be OK.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/