Re: [PATCH] i386 CPU hotplug updated for -mm

[Ingo Molnar]

* Nathan Lynch <nathanl@xxxxxxxxxxxxxx> wrote:

> I fixed up the warning in cpu_down with the following patch and now am
> running with that + 2.6.9-rc4-mm1 + your patch while doing continuous
> online/offline and make -j8.  It's been running for about 45 minutes
> and I haven't seen the panic yet, although I'm at a loss to explain
> why the change would fix it.  Will let it run overnight and report
> back...

>  	/* Move it here so it can run. */
> -	kthread_bind(p, smp_processor_id());
> +	kthread_bind(p, get_cpu());
> +	put_cpu();

>  	/* CPU is completely dead: tell everyone.  Too late to complain. */
>  	if (notifier_call_chain(&cpu_chain, CPU_DEAD, (void *)(long)cpu)

hm, is there any assurance that smp_processor_id() == cpu?

but i agree, this fix shouldnt impact the bio-destruct slab crash you
were seeing.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/