Re: [ACPI] Re: [PATCH/RFC] exposing ACPI objects in sysfs

[Andi Kleen]

On Tue, Sep 21, 2004 at 07:26:25PM +0200, Pavel Machek wrote:
> > +struct special_cmd {
> > +        u32                     magic;
> > +        unsigned int            cmd;
> > +        char                    *args;
> > +};
> 
> Talk to Andi Kleen; passing such structures using read/write is evil,
> because (unlike ioctl) there's no place to put 32/64bit
> translation. Imagine i386 application running on x86-64 system.

Yes, Pavel is right. Please don't pass pointers by read/write
because it cannot be 32bit emulated.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/