Re: [PATCH] cdrom: MO-drive open write fix (trivial)

[Stefan Meyknecht]

Hi,

thanks for your feedback.

Jens Axboe <axboe@xxxxxxx> wrote:
> Sorry, guess I forgot to reply on linux-kernel. What I mean is that
> MO drives should just have CDC_RAM set - it doesn't denote a
> specific device type, rather just the ability to work like a hard
> drive. If you could look into why that isn't set for your mo device
> and send a patch for that, it would be much better.

You are right. After inserting some debug messages I found out that in 
function cdrom_open_write CDC_RAM is initially set. The function 
cdrom_is_random_writable sets ram_write to 0 and therefore CDC_RAM 
gets masked out later. cdrom_is_random_writable calls 
cdrom_get_random_writable and there cdi->ops->generic_packet returns 
-5 (-EIO?). But I have no idea what to do in this case.

-- 
Stefan Meyknecht
stefan at meyknecht dot org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/