Re: [PATCH] s390: qeth performance.

From: Jörn Engel
Date: Fri Aug 06 2004 - 08:11:24 EST


On Fri, 6 August 2004 15:00:40 +0200, Martin Schwidefsky wrote:
> Jörn Engel <joern@xxxxxxxxxxxxxxxxxxxx> wrote on 06/08/2004 02:49:41 PM:
> >
> > After 50% of the patch I grew tired of it. Martin, since when do you
> > like excessive use of #ifdef?
>
> Well, it isn't so bad. Only 35 #ifdef CONFIG_QDIO_DEBUG.

Maybe our definitions of "isn't so bad" don't match. ;)
Anyway, it's a first step. No new code was added, the old debugging
mess is explicitly marked as such now. Next step would be to either
completely get rid of it or replace it with something less ugly.

Jörn

--
Beware of bugs in the above code; I have only proved it correct, but
not tried it.
-- Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/