Re: Inclusion of UML in 2.6.8

From: Christoph Hellwig
Date: Sat Jun 26 2004 - 13:11:53 EST


On Sat, Jun 26, 2004 at 07:05:22PM +0200, BlaisorBlade wrote:
> Andrew, what are the requisite for stable inclusion of the UML update inside
> 2.6-mm (or directly 2.6.8)? Currently (splitting out a little piece, which
> should not be included) we have almost all the stuff inside arch/um and
> include/asm-um, the addition of <linux/ghash.h> and of two filesystems for
> UML use only, and this little hunk (plus 2 uses of it inside
> mm/page_alloc.c).
>
> +#ifndef HAVE_ARCH_FREE_PAGE
> +static inline void arch_free_page(struct page *page, int order) { }
> +#endif
>
> Could it go in as-is? I'm especially worried about having it included soon in
> 2.6.8, since last time it entered -mm and stayed there just for one release.

Please send split patches. E.g. linux/ghash.h should not ne reintroduced,
it's completely fuly. Also your above arch_free_page needs some more
discussion.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/