Re: Resume enhancement: restore pci config space

From: Pavel Machek
Date: Mon May 31 2004 - 08:41:09 EST


Hi!

> One can rightfully argue that the driver resume method should do this, and
> yes that is right. So the patch only does it for devices that don't have a
> resume method. Like the main PCI bridge on my testbox of which the bios so
> nicely forgets to restore the bus master bit during resume.. With this patch
> my testbox resumes just fine while it, well, wasn't all too happy as you can
> imagine without a busmaster pci bridge.
...
> +/*
> + * Default resume method for devices that have no driver provided resume,
> + * or not even a driver at all.
> + */
> +static void pci_default_resume(struct pci_dev *pci_dev)
> +{

Perhaps this should not be static so that drivers don't
need to duplicate this?
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/