Re: [PATCH] remove net driver ugliness that sparse complains about

[Andreas Schwab]

Jeff Garzik <jgarzik@xxxxxxxxx> writes:

> @@ -3680,7 +3680,7 @@
>  	case SIOCETHTOOL:
>  		return bond_ethtool_ioctl(bond_dev, ifr);
>  	case SIOCGMIIPHY:
> -		mii = (struct mii_ioctl_data *)&ifr->ifr_data;
> +		mii = if_mii(&ifr);
>  		if (!mii) {
>  			return -EINVAL;
>  		}
> @@ -3691,7 +3691,7 @@
>  		 * We do this again just in case we were called by SIOCGMIIREG
>  		 * instead of SIOCGMIIPHY.
>  		 */
> -		mii = (struct mii_ioctl_data *)&ifr->ifr_data;
> +		mii = if_mii(&ifr);

These two look wrong, too many &.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/