Re: Bug#250477: kernel-source-2.4.26: Lots of debug in RAID5

[hch]

On Sun, May 23, 2004 at 08:53:51PM +1000, Herbert Xu wrote:
> > --- kernel-source-2.4.26/drivers/md/raid5.c	2003-08-30 06:01:38.000000000 +0000
> > +++ kernel-source-2.4.26-nodebug/drivers/md/raid5.c	2004-05-23 08:54:36.000000000 +0000
> > @@ -282,7 +282,7 @@
> >  				}
> >  
> >  				if (conf->buffer_size != size) {
> > -					printk("raid5: switching cache buffer size, %d --> %d\n", oldsize, size);
> > +					PRINTK("raid5: switching cache buffer size, %d --> %d\n", oldsize, size);
> >  					shrink_stripe_cache(conf);
> >  					if (size==0) BUG();
> >  					conf->buffer_size = size;
> 
> Thanks for the patch.  This does indeed look like a typo.
> 
> Hi Neil, does this patch look OK to you?

No, this was rejected a few times already.  The problem is that XFS
uses differen I/O sizes for the log and other I/O which makes raid
performance suck really badly.  The real fix is to use the v2 XFS log
format when using software raid5.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/