Re: [PATCH] fixing sendfile on 64bit architectures

[David Mosberger]

>>>>> On Thu, 20 May 2004 14:56:58 -0700, Andrew Morton <akpm@xxxxxxxx> said:

  >> I think the current patch is an improvement, so unless someone
  >> comes up with something better, I'd like to see it applied.

  Andrew> I do agree that ARCH_WANT_FOO is easier to understand and
  Andrew> more idiomatic.

That is true.  Actually, now that I have ARCH_OMIT, it's pretty easy
to write a script to do the complement, so the risk of introducing
errors is quite small.  Let me see what this looks like.

  Andrew> An alternative might be to remove all the ifdefs, build with
  Andrew> -ffunction-sections and let the linker drop any unreferenced
  Andrew> code...

Yeah, that might be an option.  -ffunction-sections does bad things to
link-time, though, and I'm not sure I like the idea of having a
bazillion of tiny little sections.

	--david
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/