Re: [PATCH] fixing sendfile on 64bit architectures

[Andrew Morton]

David Mosberger <davidm@xxxxxxxxxxxxxxxxx> wrote:
>
> >>>>> On Thu, 20 May 2004 20:35:32 +0100, Christoph Hellwig <hch@xxxxxxxxxxxxx> said:
> 
>   Christoph> IMHO this is exactly the wrong way around.  It should be
>   Christoph> __ARCH_WANT_* or something like that so new architectures
>   Christoph> don't carry the old garbage around by default.  There's
>   Christoph> far too many new architectures keeping old syscalls by
>   Christoph> accident.
> 
> Feel free to do that.  I was trying not to break anything and I'm
> _certain_ I would have gotten it wrong if I had reversed the sense.
> 
> I think the current patch is an improvement, so unless someone comes
> up with something better, I'd like to see it applied.

I do agree that ARCH_WANT_FOO is easier to understand and more idiomatic.

An alternative might be to remove all the ifdefs, build with
-ffunction-sections and let the linker drop any unreferenced code...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/