Re: Bug#234976: kernel-source-2.6.4: Software Suspend doesn't work

[Nigel Cunningham]

Hi.

On Wed, 28 Apr 2004 09:24:11 +1000, Benjamin Herrenschmidt  
<benh@xxxxxxxxxxxxxxxxxxx> wrote:
> Which, as I keep saying, is plain broken ... You simply cannot control
> what side effects the compiler will generate, like touching the stack,
> etc... Such a critical routine _has_ to be written in assembly (and
> properly commented of course). Anything else is asking for trouble.

No, it doesn't have to be written in assembly. If that was the case, I  
wouldn't have managed to get it working under a variety of compiler  
versions already. So long as assemblers honour the directives, we're okay.  
Of course I'll freely admit that hand coding would probably result in  
nicer, tidier and maybe faster code, and you would know that it was doing  
the right thing. In the long time I would prefer to do that. But right now  
I'm being a pragmatist: .c works, I don't know x86 assembly and don't have  
the time to learn it and the code is still changing a little, so I'll  
delay making a .S file for now.

Please, forgive me!

Regards,

Nigel
--
Nigel Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614, Australia.
+61 (2) 6251 7727 (wk)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/