Re: Bug#234976: kernel-source-2.6.4: Software Suspend doesn't work

From: Benjamin Herrenschmidt
Date: Tue Apr 27 2004 - 18:36:41 EST


> ged, anyway...
>
> Could do. And on the top of merging, sorry for the delays I'm getting
> there. I figured out yesterday what was holding me back with getting SMP &
> HighMem going under 2.6. It was really simple: the compile was using -O2.
> A quick change to the Makefile and I can now use a C file as I do with 2.4.

Which, as I keep saying, is plain broken ... You simply cannot control
what side effects the compiler will generate, like touching the stack,
etc... Such a critical routine _has_ to be written in assembly (and
properly commented of course). Anything else is asking for trouble.

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/