Re: Bug#234976: kernel-source-2.6.4: Software Suspend doesn't work

[Pavel Machek]

Hi!

> > This should be better solution, could anyone test it? [It compiles,
> > and I'm out of time now].
> 
> Well it still doen't solve the non-PSE case since you're only copying the
> top-level page table.

Yes, right, but your patch does not solve that, too, right?
Someone else will have to do that one.

Rather than adding up-to 4M of nonsave pagetables, turning off
paging might be solution there. 
  
And this will actually help. If we move saving few statments before,
we'll have identity mapping so we can turn paging off...

> > --- tmp/linux/arch/i386/power/cpu.c	2003-09-28 22:05:30.000000000 +0200
> > +++ linux/arch/i386/power/cpu.c	2004-04-27 14:44:03.000000000 +0200
> > @@ -35,6 +35,9 @@
> >  unsigned long saved_context_esi, saved_context_edi;
> >  unsigned long saved_context_eflags;
> >  
> > +/* Special page directory for resume */
> > +char swsusp_pg_dir[PAGE_SIZE];
> > +
> 
> You forgot to mark this as nosave.

Hmmm, right. Well, it should work anyway because this is
same in new and old kernel, so I'd still like some testing.
				Pavel
-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/