Re: Bug#234976: kernel-source-2.6.4: Software Suspend doesn't work

From: Herbert Xu
Date: Tue Apr 27 2004 - 07:58:07 EST


On Tue, Apr 27, 2004 at 02:48:38PM +0200, Pavel Machek wrote:
>
> This should be better solution, could anyone test it? [It compiles,
> and I'm out of time now].

Well it still doen't solve the non-PSE case since you're only copying the
top-level page table.

> --- tmp/linux/arch/i386/power/cpu.c 2003-09-28 22:05:30.000000000 +0200
> +++ linux/arch/i386/power/cpu.c 2004-04-27 14:44:03.000000000 +0200
> @@ -35,6 +35,9 @@
> unsigned long saved_context_esi, saved_context_edi;
> unsigned long saved_context_eflags;
>
> +/* Special page directory for resume */
> +char swsusp_pg_dir[PAGE_SIZE];
> +

You forgot to mark this as nosave.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/