Re: [PATCH] ppc64: create dma_mapping_error

[James Bottomley]

What exactly are you guys doing?

The API Anton introduced:  dma_mapping_error() takes only a virtual
address as the argument (no struct device or anyting), so the additional
API's pci_dma_mapping_error() and vio_dma_mapping_error have absolutely
no choice but to do the same thing as dma_mapping_error() (because the
error return cannot be bus or device specific).

So, why bother introducing all these superfluous APIs in the first
place?  Just stick to the single dma_mapping_error(); it will be much
easier.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/