Re: [patch] PCI Express Enhanced Config Patch - 2.6.0-test11

From: Christoph Hellwig
Date: Wed Jan 28 2004 - 09:55:50 EST


On Wed, Jan 28, 2004 at 04:42:52PM +0200, Vladimir Kondratiev wrote:
> My inputs:
>
> - I do not like pci_express_read implemented as inline function. It is
> called only in one place. It is more appropriate, on my opinion, to
> merge all stuff added to include/asm-i386/pci.h , into
> arch/i386/pci/direct.c.

Actually it should be in a file of it's own, e.g. arch/i386/pci/express.c

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/