Re: PATCH: Shutdown IDE before powering off.

From: Jeff Garzik
Date: Thu Jan 22 2004 - 11:04:17 EST


Andrew Morton wrote:
Nigel Cunningham <ncunningham@xxxxxxxxxxxxxxxxxxxxx> wrote:

Hi.

On Thu, 2004-01-22 at 21:13, John Bradford wrote:

This spins down the disk(s) when you're just doing do a reboot. That's
fairly irritating and could affect reboot times if one has many disks.

I think it is an attempt to force some broken drives to flush their
cache, but I wonder whether it will simply move the problem from one
set of broken drives to another :-).

Yes, they were trying to get caches flushed. If this attempt is
misguided, that's fine. Is there a better way?


A couple of thoughts come to mind:

a) Don't do it if the user typed reboot - only do it if we're powering down.

b) Try to do a cache flush instead. If that fails (do we know?) then
power down the disk instead.


I'm either shock or very very worried that the reboot notifier that flushes IDE in 2.4.x, ide_notifier, is nowhere to be seen in 2.6.x :( That seems like the real problem -- the code _used_ to be there.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/