Re: [PATCH 2.6] Warnings in 8250_acpi

From: Russell King
Date: Mon Oct 06 2003 - 03:40:03 EST


On Mon, Oct 06, 2003 at 01:31:55AM -0500, Dmitry Torokhov wrote:
> Lastest changes in 8250_acpi.c produce warnings about type mismatch
> in printk. We could either change format to print long long arguments
> or, until most of us are on 64 bits, just trim values to 32.

I'd like Bjorn to comment before I apply this.

--- 1.3/drivers/serial/8250_acpi.c Wed Oct 1 04:11:17 2003
+++ edited/drivers/serial/8250_acpi.c Mon Oct 6 01:18:22 2003
@@ -28,8 +28,9 @@
req->iomem_base = ioremap(req->iomap_base, size);
if (!req->iomem_base) {
printk(KERN_ERR "%s: couldn't ioremap 0x%lx-0x%lx\n",
- __FUNCTION__, addr->min_address_range,
- addr->max_address_range);
+ __FUNCTION__,
+ (unsigned long)addr->min_address_range,
+ (unsigned long)addr->max_address_range);
return AE_ERROR;
}
req->io_type = SERIAL_IO_MEM;

--
Russell King (rmk@xxxxxxxxxxxxxxxx) http://www.arm.linux.org.uk/personal/
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/