Re: [PATCH][2.6][CFT] rmmod floppy kills box fixes + default_device_remove

[Zwane Mwaikambo]

On Mon, 8 Sep 2003, Greg KH wrote:

> Ick, no, I do not want to see this function get added, sorry.

Well i was expecting that.

> What happens if someone grabs the struct device reference by opening a
> sysfs file and then you unload the module?  Yeah, not nice.  Please do

Doesn't this all get taken care of by the platform_device_unregister?

> _not_ create "empty" release() functions, unless you _really_ know what
> you are doing (and providing a "default" one like this is just ripe for
> abuse, that warning message in the kernel is there for a reason.)

I know it's begging for abuse, but i don't want to sprinkle empty 
release() functions everywhere, e.g. looking at the floppy driver, i'm 
not quite sure what i'm supposed to do with a release() function there, 
the struct platform_device_struct is statically allocated. Basically i'd 
like a pointer as to what to do with these release() functions..

Thanks,
	Zwane
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/