Re: dontdiff for 2.6.0-test4

From: Herbert Poetzl
Date: Mon Sep 01 2003 - 11:55:48 EST


On Mon, Sep 01, 2003 at 06:22:44PM +0200, Sam Ravnborg wrote:
> On Mon, Sep 01, 2003 at 04:39:58PM +0100, Christoph Hellwig wrote:
> > > I have updated dontdiff in the usual place:
> > > http://www.moses.uklinux.net/patches/dontdiff
> > > /usr/src/linux/Documentation/SubmittingPatches
> >
> > Btw, what about putting this somewhere in the kernel tree?
>
> I do not like dontdiff to be part of the kernel tree.
> What is included in dontdiff is redundant information already known
> by kbuild. Effectively dontdiff should not list any files that would
> not be removed during a "make mrproper".

I have to agree, do not get me wrong, dontdiff might be very
useful, although I personally do not use it to create kernel
patches, but IMHO it should be autogenerated not handcrafted

best,
Herbert

> Instead why not use the knowledge kbuild has and implement
> 'make dontdiff'
>
> This could generate the list of files used for 'diff -X'.
> I can try to hack up something during the week just to see if
> it looks ok.
>
> Sam
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/