Re: [NOTAPATCH] Re: [PATCH] O6int for interactivity

From: Mike Galbraith (efault@gmx.de)
Date: Mon Jul 21 2003 - 12:13:04 EST


At 02:39 PM 7/21/2003 +0200, Mike Galbraith wrote:
>... Comments on the attached [kiss] approach?

In case anyone decides to take a look, there's a line missing which was
supposed to advance the timeout in the case where we haven't yet timed out,
and the task is not interactive. A better way to do what I intended is to
change...

      if (rq->idx && TASK_INTERACTIVE(p))
           rq->interval_ts++
to
      if (!rq->idx - !TASK_INTERACTIVE(P) == 0)
            rq->interval_ts++;

With this diff in place, and with bonnie and a make bzImage sharing my cpu
with irman2, I see no terminal starvation. Both the make and bonnie are
proceeding just fine.

         ciao,

         -Mike

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jul 23 2003 - 22:00:43 EST