Re: [PATCH] xirc2ps_cs irq return fix

From: Zwane Mwaikambo (zwane@linuxpower.ca)
Date: Sun May 25 2003 - 20:15:49 EST


On Sun, 25 May 2003, Jeff Garzik wrote:

> As I mentioned in the thread, this piece of code is obviously wrong.
>
> Think about how scalable this fix is?? Do you really want to crap up
> all pcmcia drivers with this silly -- and wrong -- check?

My interpretation of it is the PCMCIA controller was triggering interrupts
on exit and the link handler for the card was still installed even after
the netdevice was down.

> IIRC the pcmcia layer or new irqreturn_t was blamed for the problem.
> Come on. Linux mantra is -against- papering over bugs.

I have to take responsibility for that little mess :(

Zwane
--
function.linuxpower.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/