Re: [PATCH] xirc2ps_cs irq return fix

[Jeff Garzik (jgarzik@pobox.com)]

Linux Kernel Mailing List wrote:
> diff -Nru a/drivers/net/pcmcia/xirc2ps_cs.c b/drivers/net/pcmcia/xirc2ps_cs.c
> --- a/drivers/net/pcmcia/xirc2ps_cs.c	Sun May 25 16:18:34 2003
> +++ b/drivers/net/pcmcia/xirc2ps_cs.c	Sun May 25 16:18:34 2003
>      if (!netif_device_present(dev))
> -	return IRQ_NONE;
> +	return IRQ_HANDLED;

As I mentioned in the thread, this piece of code is obviously wrong.

Think about how scalable this fix is??  Do you really want to crap up 
all pcmcia drivers with this silly -- and wrong -- check?

IIRC the pcmcia layer or new irqreturn_t was blamed for the problem. 
Come on.  Linux mantra is -against- papering over bugs.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/