Re: [patch] cache flush bug in mm/filemap.c (all kernels >= 2.5.30(at least))

From: David S. Miller (davem@redhat.com)
Date: Fri May 23 2003 - 05:15:05 EST


   From: Andrew Morton <akpm@digeo.com>
   Date: Fri, 23 May 2003 03:04:09 -0700

   "David S. Miller" <davem@redhat.com> wrote:
> I agree. Someone should take a close look at the do_file_page()
> code paths to make sure that's still kosher after such a change.
   
   What would one be looking for? I don't know what the sideeffects of
   update_mmu_cache() might be.
   
   It looks to be the same as do_no_page() though: the update_mmu_cache() is
   the last substantive thing which happens in the fault or the syscall.
   
Yes, this is what I was talking about, making sure do_file_page()'s
return path isn't doing a update_mmu_cache() call already.

I don't believe this is an error (to do it twice for the same fault)
but it would be superfluous.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri May 23 2003 - 22:00:54 EST