Re: [patch] HT scheduler, sched-2.5.59-D7

From: Manfred Spraul (manfred@colorfullife.com)
Date: Mon Jan 20 2003 - 16:59:26 EST


Ingo wrote:

>--- linux/fs/pipe.c.orig 2003-01-20 19:28:43.000000000 +0100
>+++ linux/fs/pipe.c 2003-01-20 22:58:35.000000000 +0100
>@@ -117,7 +117,7 @@
> up(PIPE_SEM(*inode));
> /* Signal writers asynchronously that there is more room. */
> if (do_wakeup) {
>- wake_up_interruptible(PIPE_WAIT(*inode));
>+ wake_up_interruptible_sync(PIPE_WAIT(*inode));
> kill_fasync(PIPE_FASYNC_WRITERS(*inode), SIGIO, POLL_OUT);
> }
> if (ret > 0)
>
What's the purpose of this change?
I thought that the _sync functions should be called if it's guaranteed
that schedule() will be called immediately, i.e. if the scheduler should
not rebalance.
You've added _sync() to the codepaths that lead to the end of the syscall.

--
    Manfred

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jan 23 2003 - 22:00:25 EST