Looks OK to me; as soon as you decide how the low-level driver should
limit the baud rate, I'll update nb85e_uart.c to do it (storing max/min in
the uart_port structure, as someone suggested, seems pretty convenient).
If unsupported termios flags are passed in, what should the low-level
function do? Tweak the contents of *termios to reflect reality?
BTW, why the name `settermios'? Something like `set_termios' seems easier
to read and more in keeping with the style used elsewhere in the
serial-port code. [settermios brings back horrible memories of BSD kernel
code...]
Thanks,
-miles
-- Run away! Run away! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Jan 07 2003 - 22:00:31 EST