Re: [PATCH] 10: 2.5.29-wdt977

From: Sam Ravnborg (sam@ravnborg.org)
Date: Sat Aug 03 2002 - 15:50:53 EST


On Sat, Aug 03, 2002 at 07:16:18PM +0100, Russell King wrote:
> Bitops are used with on the timer_alive variable. Therefore, timer_alive
> needs to be "unsigned long" not "int".

How about:
> -static int timer_alive;
> +static bitmap_member(timer_alive, 1);

In this way it is obviously used for bitops.

Rusty's more informative DECLARE_BITMAP (IIRC) patch has not yet been
accepted by Linus, otherwise it would better tell people that this is
actually a macro without the need to parse the declaration first.

        Sam

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Aug 07 2002 - 22:00:24 EST