David Howells wrote:
>
> Hi Linus,
>
> This patch moves task_struct allocation from kernel/fork.c into
> arch/*/kernel/process.c.
>
> David Mosberger wrote:
>
> > David.H> What might be worth doing is to move the task_struct slab
> > David.H> cache and (de-)allocator out of fork.c and to stick it in
> > David.H> the arch somewhere. Then archs aren't bound to have the two
> > David.H> separate. So for a system that can handle lots of memory,
> > David.H> you can allocate the thread_info, task_struct and
> > David.H> supervisor stack all on one very large chunk if you so
> > David.H> wish.
> >
> > Could you do this? I'd prefer if task_info could be completely hidden
> > inside the x86/sparc arch-specific code, but if things are set up such
> > that we at least have the option to keep the stack, task_info, and
> > task_struct in a single chunk of memory (and without pointers between
> > them), I'd have much less of an issue with it.
Is this the first in a multi-step patch series, or something like that?
You just duplicated code in a generic location and pasted it into the
arch. Where's the gain in that? I do see the gain in letting the arch
allocate the task struct, but surely your patch should provide a generic
mechanism for an arch to call by default, instead of duplicating code??
Jeff
-- Jeff Garzik | "I went through my candy like hot oatmeal Building 1024 | through an internally-buttered weasel." MandrakeSoft | - goats.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Feb 15 2002 - 21:01:02 EST