Re: patch: aio + bio for raw io

From: Benjamin LaHaise (bcrl@redhat.com)
Date: Fri Feb 08 2002 - 17:02:57 EST


On Fri, Feb 08, 2002 at 03:10:09PM +0530, Suparna Bhattacharya wrote:
> You chose to add a kvec_cb field to the bio structure rather than use
> bi_private ?

Yup. I'm lazy. Also, the cb struct actually needs 2 pointers, so just
bi_private isn't enough.

> For the raw path, you are OK since you never have to copy data out of
> the kvecs after i/o completion, and unmap_kvec only looks at veclet pages.
> So the fact block can change the offset and len fields in the veclets
> doesn't affect you, but thought I'd mention it as a point of caution
> anyhow ...

Ugh. That sounds like something bio should not be doing. If someone
wants to fix it, such a patch would be much appreciated, otherwise it'll
wait until I'm back in Canada.

                -ben
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 15 2002 - 21:00:23 EST