Re: [patch] truncate fixes

From: Alexander Viro (
Date: Mon Jan 07 2002 - 00:24:26 EST

On Sun, 6 Jan 2002, Andrew Morton wrote:

> Andrea Arcangeli wrote:
> >
> > I prefer my fix that simply recalls the ->truncate callback if -ENOSPC
> > is returned by prepare_write. vmtruncate seems way overkill,
> No opinion on that here. This is what was in -ac. Perhaps Al can
> comment?

a) It's obviously correct
b) it's a friggin error-handling path and I'll take correctness over
anything here.

Keep in mind that you want to zero the area out, so at the very least
truncate_inode_pages() + ->truncate() are needed. And locking/ordering
consideration here are tricky enough to make duplicating them a Bad

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Jan 07 2002 - 21:00:33 EST