Re: [patch] truncate fixes

From: Andrew Morton (
Date: Sun Jan 06 2002 - 21:53:30 EST

Andrea Arcangeli wrote:
> I prefer my fix that simply recalls the ->truncate callback if -ENOSPC
> is returned by prepare_write. vmtruncate seems way overkill,

No opinion on that here. This is what was in -ac. Perhaps Al can

> and after
> calling ->truncate the __block_prepare_changes above won't be necessary
> because the leftover will be correctly deallocated (no need to clear
> them out and to mark them dirty, they will just go away before any
> readpage can see them).

No, this code is needed if the write is _inside_ i_size, to an
uninstantiated block. truncate won't remove those blocks, and we've
gone and added them to the file.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Jan 07 2002 - 21:00:33 EST