Re: please revert bogus patch to vmscan.c

From: Hugh Dickins (hugh@veritas.com)
Date: Mon Oct 29 2001 - 19:02:53 EST


On Mon, 29 Oct 2001, Benjamin LaHaise wrote:
> Think of CPUs with tagged tlbs and lots of entries. Or even a system that
> only runs 1 threaded app. Easily triggerable. If people want to optimise
> it, great. But go for correctness first, please...

But was the original flush_tlb_page() fully correct? In i386 it's
        if (vma->vm_mm == current->active_mm)
                __flush_tlb_one(addr);
without reference to whether vma->vm_mm is active on another cpu.

Hugh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Oct 31 2001 - 21:00:38 EST