Re: [PATCH] net/ipv4/arp.c, kernel 2.4.6 - PROXY_ARP bug on shaper device

From: David S. Miller (
Date: Sat Jul 28 2001 - 06:43:12 EST

Roberto Arcomano writes:
> Solution: The patch investigates about the shaper device
> (it compares string with "shaper"): if yes, we
> search the real interface attached to shaper
> (we read value of priv->dev) and we use that to
> make the classic proxy arp devices compare.
> Problems: The patch uses routine "strncmp" which is not the
> best thing (I guess).

This is gross, make a device flag and have shaper set that
flag during shaper device init, then have ARP test it.

Make the name of the flag reflect what the attribute is that shaper
has (and potentially other devices could have) which makes this ARP
special case necessary. Ie. don't name the flag NETIF_F_SHAPER :-)

David S. Miller
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Tue Jul 31 2001 - 21:00:37 EST