Re: correction: fs/buffer.c underlocking async pages

From: Chris Mason (mason@suse.com)
Date: Thu Jun 21 2001 - 13:20:45 EST


On Thursday, June 21, 2001 07:15:22 PM +0200 Andrea Arcangeli
<andrea@suse.de> wrote:

> On Thu, Jun 21, 2001 at 09:56:04AM -0700, Linus Torvalds wrote:
> What's the problem with the existing code, and why do people want to add
> a
>> (unnecessary) new bit?
>
> there's no problem with the existing code, what I understood is that
> they cannot overwrite the ->b_end_io callback in the lowlevel blkdev
> layer or the page will be unlocked too early.

Just to be more explicit, the big problem is mixing different async
callbacks on the same page. The patch would also allow things like this:

fs_specific_end_io() {
    do something special
    end_buffer_io_async()
}

-chris

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 23 2001 - 21:00:33 EST