Re: Loop encryption module locking bug (linux-2.4.5).

From: Andi Kleen (
Date: Thu Jun 21 2001 - 07:36:58 EST

I think your mail is offtopic for linux-kernel: it doesn't mention Microsoft or user space
java programming or pointer to random unrelated web pages, but an actual kernel bug.

Ingo Rohloff <> writes:
> If lo_open doesn't call the cipher lock function and
> lo_release doesn't call the cipher unlock function, the issue
> is resolved. (So code gets deleted in the patch.)

I think it would be better if the low level module stays locked also while the
control fd is open. That would match the semantics of most other devices.

Right fix probably is to call ->lock twice in loop_set_status()

[Also the locking is not SMP safe, but that's a different issue, for the e.g. ->lock
would need to be replaced with a struct module *owner and also some other locking]

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sat Jun 23 2001 - 21:00:31 EST