Re: [patch] set kiobuf io_count once, instead of increment

From: Robert Read (
Date: Wed Feb 28 2001 - 12:18:59 EST

On Tue, Feb 27, 2001 at 10:50:54PM -0300, Marcelo Tosatti wrote:
> It seems your patch breaks bh allocation failure handling. If
> get_unused_buffer_head() fails, iobuf->io_count never reaches 0, so
> processes waiting on kiobuf_wait_for_io() will block forever.

This is true, but it looks like the brw_kiovec allocation failure
handling is broken already; it's calling __put_unused_buffer_head on
bhs without waiting for them to complete first. Also, the err won't
be returned if the previous batch of bhs finished ok. It looks like
brw_kiovec needs some work, but I'm going to need some coffee first...

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Wed Feb 28 2001 - 21:00:17 EST