Re: Compatibility issue with 2.2.19pre7

From: Trond Myklebust (trond.myklebust@fys.uio.no)
Date: Thu Jan 11 2001 - 13:22:03 EST


>>>>> " " == Trond Myklebust <trond.myklebust@fys.uio.no> writes:

> - if (file->f_handle.fh_dcookie == fh->fh_dcookie &&
> - !memcmp(&file->f_handle, fh, sizeof(*fh)))
> + if (file->f_handle.fh_dcookie == fh.fh_dcookie &&
> + !memcmp(&file->f_handle, &fh, sizeof(fh)))
> goto found;

Come to think of it, this line looks pretty insane. Why on earth are
we testing fh_dcookie twice?

I suspect that just the elimination of the redundant comparison in the
above line would eliminate Russell's problem entirely, given that it's
the only place in the entire routine where we actually reference
fh->fh_base.fb_dentry.

In all other cases, we're referencing ordinary integers. Are there any
alignment requirements on them?

Cheers,
  Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jan 15 2001 - 21:00:31 EST